Skip to content

Trackextension: use http://alice-ccdb.cern.ch#275

Merged
jgrosseo merged 1 commit into
masterfrom
sawenzel-patch-1
Nov 12, 2021
Merged

Trackextension: use http://alice-ccdb.cern.ch#275
jgrosseo merged 1 commit into
masterfrom
sawenzel-patch-1

Conversation

@sawenzel

Copy link
Copy Markdown
Contributor

Trackextension is the only part of the code that uses https://alice-ccdb.cern.ch. A simple
move to http: should solve the problem with certificates discussed on mattermost.

This would also follow
the approach in many other places of the code (see git grep alice-ccdb).

Maybe the CCDB location should be a global property for all tasks anyway.

Trackextension is the only part of the code that uses https://alice-ccdb.cern.ch. A simple
move to `http:` should solve the problem with certificates discussed on mattermost. 

This would also follow
the approach in many other places of the code (see `git grep alice-ccdb`).

Maybe the CCDB location should be a global property for all tasks anyway.
@sawenzel sawenzel requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners November 12, 2021 11:19
const char* ccdbpath_geo = "GLO/Config/Geometry";
const char* ccdbpath_grp = "GLO/GRP/GRP";
const char* ccdburl = "https://alice-ccdb.cern.ch"; /* test "http://alice-ccdb.cern.ch:8080"; */
const char* ccdburl = "http://alice-ccdb.cern.ch"; /* test "http://alice-ccdb.cern.ch:8080"; */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe 8080 still needs to be added

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 8080 points to the test instance...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't put https then you have to put 8080 which is the test endpoint

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap!
You're right!
Sorry for the noise!

@jgrosseo

Copy link
Copy Markdown
Contributor

Trackextension is the only part of the code that uses https://alice-ccdb.cern.ch. A simple move to http: should solve the problem with certificates discussed on mattermost.

This would also follow the approach in many other places of the code (see git grep alice-ccdb).

Maybe the CCDB location should be a global property for all tasks anyway.

Thanks Sandro. Yes, the plan is to have this global with the CCDBConfigurable. Ongoing.

@jgrosseo jgrosseo enabled auto-merge (squash) November 12, 2021 11:23
@jgrosseo jgrosseo disabled auto-merge November 12, 2021 11:23
@jgrosseo jgrosseo enabled auto-merge (squash) November 12, 2021 11:23
@jgrosseo jgrosseo disabled auto-merge November 12, 2021 11:26
@jgrosseo

Copy link
Copy Markdown
Contributor

@sawenzel did you try this?

@jgrosseo jgrosseo enabled auto-merge (squash) November 12, 2021 11:41
@jgrosseo jgrosseo merged commit f7e0e21 into master Nov 12, 2021
@jgrosseo jgrosseo deleted the sawenzel-patch-1 branch November 12, 2021 14:59
njacazio pushed a commit that referenced this pull request Apr 2, 2024
* PWGLF: Add tof NSigma Cascade tester

* Please consider the following formatting changes (#275)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
* PWGLF: Add tof NSigma Cascade tester

* Please consider the following formatting changes (AliceO2Group#275)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
* PWGLF: Add tof NSigma Cascade tester

* Please consider the following formatting changes (AliceO2Group#275)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants